fix: use single newline for commit message list

bobvanderlinden · Oct 30, 2019 · 4e1202b · 4e1202b
1 parent fa97d75
commit 4e1202b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/commit-message.ts b/src/commit-message.ts
@@ -34,9 +34,9 @@ function getCustomCommitMessage (
     body: pullRequestInfo => pullRequestInfo.body,
     number: pullRequestInfo => pullRequestInfo.number.toString(),
     branch: pullRequestInfo => pullRequestInfo.headRefName,
-    commits: pullRequestInfo => pullRequestInfo.allCommits.nodes.map(node => {
-      return `* ${node.commit.messageHeadline} (${node.commit.abbreviatedOid})`
-    }).join('\n\n')
+    commits: pullRequestInfo => pullRequestInfo.allCommits.nodes
+      .map(node => `* ${node.commit.messageHeadline} (${node.commit.abbreviatedOid})`)
+      .join('\n')
   }
 
   return template.replace(/\{(\w+)\}/g, (match, tagName: Tag) => {

diff --git a/test/commit-message.test.ts b/test/commit-message.test.ts
@@ -92,7 +92,7 @@ describe('getCommitMessage', () => {
     const config = createConfig({
       mergeCommitMessage: '{commits}'
     })
-    expect(getCommitMessage(pullRequestInfo, config)).toEqual('* commit-1 (1111111)\n\n* commit-2 (2222222)')
+    expect(getCommitMessage(pullRequestInfo, config)).toEqual('* commit-1 (1111111)\n* commit-2 (2222222)')
   })
 
   it('returns multiple template tags', () => {