Add pullRequestAuthorRole

[abelsiqueira]

Let me know how I can improve it.

Closes #707

[bobvanderlinden]

This is already looking quite good! Some suggestions and I think this also needs an addition in the readme.

[bobvanderlinden]

The type of requiredAuthorRole in config.ts can be CommentAuthorAssociation. In addition, the readme needs a section for the new option.

[bobvanderlinden]

Looks good to me now 👍 Let me know whether you have any changes in mind. If not, I'll merge and deploy this to production.

[abelsiqueira]

Thanks for the update. From what I understood, we'll write something like

rules:
  - pullRequestOwnerRole: CommentAuthorAssociation.OWNER
    minApprovals:
      OWNER: 1
  - minApprovals:
      OWNER: 2

is that correct?

[bobvanderlinden]

Yes, that should be possible. Best would be to create an integration test for your explicit case if you want to be sure this will work now and in the future.

Example of a similar integration test can be found here:

probot-auto-merge/test/integration.test.ts

Lines 305 to 352 in 6e4efcf

	it('to merge when one rule and the global configuration passes', async () => {
	const config = `
	rules:
	- minApprovals:
	OWNER: 1
	- requiredLabels:
	- merge
	`
	const pullRequestInfo = createPullRequestInfo({
	reviews: {
	nodes: [
	approvedReview({
	authorAssociation: CommentAuthorAssociation.CONTRIBUTOR
	})
	]
	},
	commits: createCommitsWithCheckSuiteWithCheckRun({
	checkRun: successCheckRun
	}),
	labels: {
	nodes: [
	{ name: 'merge' }
	]
	}
	})
	const github = createGithubApiFromPullRequestInfo({
	pullRequestInfo,
	config
	})
	const app = createApplication({
	appFn,
	logger: createEmptyLogger(),
	github
	})
	await app.receive(
	createPullRequestOpenedEvent({
	owner: 'bobvanderlinden',
	repo: 'probot-auto-merge',
	number: 1
	})
	)
	expect(github.pulls.merge).toHaveBeenCalled()
	})

[abelsiqueira]

Sorry for the very long delay. I've created a test and hopefully it will work now.

[bobvanderlinden]

Thanks for the work! This looks really useful and the implementation well-tested. Only thing missing is an addition to the README. Other than that, this looks good to merge 👍

[abelsiqueira]

Thanks, I'm glad it'll be useful. I have created a new commit with the README addition.

[github-actions]

🎉 This PR is included in version 1.3.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀