Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxi_Trip_analysis #10

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Conversation

KesharwaniArpita
Copy link

@pavithraes and @bryevdv ,I wanted to reach out to ask if you would be willing to review my recent work analyzing the taxi trip dataset and share your thoughts on it. I will be uploading more plots regarding the same in coming days. As a mentor, your guidance and feedback would be invaluable in helping me improve my skills and abilities.
If it's not too much trouble, I would appreciate any constructive criticism or suggestions you may have. I understand that you likely have many other commitments, so please let me know if and when you would be able to provide feedback.
Thank you for your time and consideration. I look forward to hearing from you.
Best regards.

@bryevdv
Copy link
Member

bryevdv commented Mar 14, 2023

Hi @KesharwaniArpita thanks for the PR, this satisfies the micro task. You have demonstrate facility with the Bokeh API already, my main comment would be that the notebooks and plots could use more "story", e.g. the plots themselves could often benefit from axis labels and other annotations like legends (especially the second plot, it's not clear what the different colors represent) and the notebooks could benefit from some narrative text or comments explaining what is to be looked at, why it is interesting, any conclusions the plots supports, etc.

Additionally, the notebooks themselves could be tidied up somewhat: empty cells and commented-out code makes things a little harder to follow at a glance.

cc @pavithraes for additional comments

@KesharwaniArpita
Copy link
Author

Thanks @bryevdv , I'll look to that :)

@bryevdv
Copy link
Member

bryevdv commented Mar 29, 2023

Hi @KesharwaniArpita thanks for your patience,there are many more submissions than we expected, and then I have unfortunately been sick all week. First off, this definitely satisfies the micro-task.

Quick thoughts: You have clearly demonstrated a good command of the Bokeh APIs. The cross-tabulation chart is especially effective. I think some of the pie charts could potentially use some attention to improve their labelling (or possibly explore other chart types as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants