New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm chart: persistence, allow kubernetes default storageClassName #84

Closed

zerthimon opened this issue Aug 19, 2021 · 1 comment

zerthimon commented Aug 19, 2021

Currently there is no way to use kubernetes default SC due to:

        {{- if (eq "-" .Values.persistence.storageClass) }}
        storageClassName: ""
        {{- else }}
        storageClassName: "{{ .Values.persistence.storageClass }}"
        {{- end }}

To use default SC, the storageClassName should not be specified at all in the volumeClaimTemplate: like this:

  volumeClaimTemplates:
    - metadata:
        name: data
      spec:
        accessModes: [ "ReadWriteOnce" ]
        resources:
          requests:
            storage: {{ .Values.worker.volume.size }}

The text was updated successfully, but these errors were encountered:

bokysan added a commit that referenced this issue


          Fix for #84: Do not set storageClassName if not set in values.yml

3cb19e7

Owner

bokysan commented Aug 22, 2021

Fixed in latest master. Setting storageClassName to an empty value will remove the element from resulting YAML.

bokysan closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment