Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed SvgPath_getDimension() behaviour for multiple sub-paths #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

redremus
Copy link

Solution for Issue #40
SvgPath_getDimension() now stores path origin on move ('m') and set abspos to it on path close ('z')

@saardrimer
Copy link
Contributor

@threebytesfull has been working on this issue in a new version of PCBmodE. I have alerted him to this PR. I will not merge this PR to the current version as it will modify expected behaviour with existing designs. @threebytesfull will evaluate this PR against his version. Thanks!

@threebytesfull
Copy link
Contributor

Ooh, that's a good spot - I hadn't found that one yet! :) I've got a load of test cases for the stuff I'd looked at so far in svgpath (tests at https://github.com/threebytesfull/pcbmode/blob/develop/tests/test_svgpath.py and corresponding code at https://github.com/threebytesfull/pcbmode/blob/develop/pcbmode/utils/svgpath.py - still work in progress!).

I had added tests for multi-step paths but not paths with close commands in between them - I'll add tests for that. I've made some fundamental changes which means my stuff can't be merged in without careful checking, hence the growing test suite. Want me to add tests and merge this PR into my develop branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants