Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Absolute_imports. Pep8 whitespace. #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cabalist
Copy link

Hey there!

I am a member of the Boldport Club and just started looking into PcbModE. I really like it so far! :) I made some changes so that the imports are loaded in the Python3 compatible style and cleaned up some whitespace in the code. I realize that it looks like a lot of changes but I mostly just added from __future__ import absolute_import at the top of the file and then updated the import statements. It should all functional identically.

Hint: Add ?w=1 to the URL to see the diff with whitespace ignored. (i.e Cabalist@452f95b?w=1)

I'd like to add some more Python3 compatibility going forward as well if you are open to it.

Thanks!

… a couple of old-style classes. Whitespace fixes.
@saardrimer
Copy link
Contributor

I know that @threebytesfull has been working on a branch (PCBmodE v5) that takes care of Python3 issues. @threebytesfull do you have any feedback on this with regards to your own work?

@threebytesfull
Copy link
Contributor

I've had a look at this - the changes all make sense but I need to merge carefully where I've moved code around... Just realised the time here so I'll have a proper go at that after work tomorrow :)

@JarrettR
Copy link

JarrettR commented Apr 30, 2018

Any movement on this? Looks quite straightforward and a great cleanup
edit whoops, ignore me:
https://github.com/threebytesfull/pcbmode/tree/develop

would be nice if that were merged into mainline soon! I'd be happy to submit better PRs if the codebase saw more active response!

@saardrimer
Copy link
Contributor

Hello @Cabalist! I'm sorry that this has take so long for me to look at. I'm starting work on a new version at branch cinco-master.

Could you direct me to a resource describing 'import loading in a Python3 compatible style'? For Cinco we'll support Python3 #45

May I also request that you issue PRs in smaller chinks so that it's easier for me to review? Also, have a look at CONTRIBUTE.md ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants