Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-131
Summary
Fix pre-commit, pre-push, Git hooks.
Details
Git hooks appeared to stop working. Actually, they are working when you commit from command line, but are skipped if you use Source Tree, as I do.
Looks like there are issues with both Husky (which we use for hooks) and Source Tree that contribute to this issue (see issue), but it can be fixed by simply downgrading Husky.
How to test
packages/components/bolt-popover/src/popover.scss (L40-41)
and switch the order of thedisplay
andposition
rules, so thatposition
comes first. This should produce a stylint error.yarn
after switching branches.