-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sframe
to libbfd's dependencies list
#296
Conversation
What is Besides, backward-cpp itself doesn't use |
I won't try to explain it, I know nothing about it. You might want to read this
It's in the
Serenity is x86_64 only.
Absolutely agree with that, still you are required to manually add |
FYI: #68 bring support for static linking of
The GNU project always intended to distribute I guess that it was decided to spare disk space at the time, but anyway, |
I don't mind the change but... will it break something on other systems? |
That's a fair point, I've made a change to make sure it's still compatible with old distributions. As far as I can see:
1.
|
90d6cc8
to
bd1defa
Compare
This is required when linking on a system without a dynamic library for libbfd. Note that `libsframe` is a recent addition to `libbfd`, so we test for the library existence before adding it to the dependency list. It allows us to remain compatible with older distributions.
So if you have sframe installed and libbfd that doesn't depend on sframe. It will link to sframe anyways? I wonder if this is one of those case where pkgconfig can help? Though that assumes those libs offer a pkgconfig configuration... Unless something new comes up, I will merge this PR in the next few days. |
Yes, but I would say that it's a non-issue. If it happens, the linker will be able to get rid of it of the object, so apart from the very small link-time overhead there are no consequences. Nonetheless, that situation shouldn't be accidentally encountered,
That would be too easy 😄. More seriously, I guess that it would be a mess to provide one, as almost all distribution hacks a
Sounds good to me, thanks! |
Ok perfect, thank you for taking the time. I am convinced this is reasonable. Merci! |
To bring some context, I tried to build
backward-cpp
for SerenityOS.We only rely on binutils' Makefile which doesn't generate a
.so
forlibbfd
. When buildingbackward-cpp
with this configuration, I faced linker errors with symbols fromsframe
. It appears thatsframe
is also a dependency oflibbfd
.FWIW, it's in phase with what Arch do to package
libbfd.so
:"echo 'INPUT( /usr/lib/libbfd.a -lsframe -liberty -lz -lzstd -ldl )' > "$pkgdir/usr/lib/libbfd.so""