Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mingw, if support "-gcodeview" add -gcodeview #301

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

mariuszmaximus
Copy link
Contributor

if support "-gcodeview" add -gcodeview, -Wl,--pdb=

I found this solution here #176 (comment)

if compiler don't support -gcodeview is old version with msvcr90

@mariuszmaximus mariuszmaximus changed the title fix for mingw Fix for mingw, if support "-gcodeview" add -gcodeview Jun 29, 2023
@bombela
Copy link
Owner

bombela commented Jun 29, 2023

Looking good. Can you clean up the indentation? It seems all over the place.

if support "-gcodeview" add  "-gcodeview", "-Wl,--pdb= "
@mariuszmaximus
Copy link
Contributor Author

tab everywhere now :)
indentation the same as the rest of the code,
or I don't understand :Can you clean up the indentation?

@bombela bombela merged commit a6629cf into bombela:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants