Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration to Svelte 4 #52

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

candidosales
Copy link

@candidosales candidosales commented Sep 18, 2024

  • Migrate to Svelte 4;
  • Fix the ESLint;
  • Fix the rollup.config;
  • Fix the CSS imports at App.svelte;
  • Improved the Icons;
  • Upgrade the most of the dependencies;
  • Upgrade project version to 0.7.0;

Considerations

  • In the following PR, it would be better to migrate the project to use SvelteKit;

Evidence

CleanShot.2024-09-17.at.23.20.08.mp4

@candidosales
Copy link
Author

@bonartm , could you review it?

@bonartm
Copy link
Owner

bonartm commented Oct 11, 2024

Thanks so much for your work.

@bonartm
Copy link
Owner

bonartm commented Oct 11, 2024

I'm getting npm ERR! Cannot read property '@fortawesome/fontawesome-svg-core' of undefined in the ci pipeline.

@gogoadl
Copy link

gogoadl commented Oct 11, 2024

It seems like dependency problem.

When I run on npm ci and using below environment, it occurs to me samely.
github action environment:

2024-10-11T07:28:29.4663705Z [command]/opt/hostedtoolcache/node/12.22.12/x64/bin/node --version
2024-10-11T07:28:29.4710413Z v12.22.12
2024-10-11T07:28:29.4721985Z [command]/opt/hostedtoolcache/node/12.22.12/x64/bin/npm --version
2024-10-11T07:28:29.5928818Z 6.14.16

But I ran it on node 20.18.0 and npm 10.8.2, then it works .
So, How about change your github build environment?
Additionally, You need to install npm ci using npm install ci before running npm ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants