Improve support for high-frequency visualizers #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
force-pushed
the
buffered-visualizers
branch
from
113b474
to
7b8fa3d
Compare
glopesdev
force-pushed
the
buffered-visualizers
branch
from
7b8fa3d
to
7e62da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new abstract visualizer class for automatically buffering value updates. This significantly reduces the number of updates to the UI thread coming from high-frequency visualizers, which also prevents crashing X11 services on the cross-platform Linux editor.
All values are still timestamped in the original notification thread before being buffered. The new backwards-compatible virtual call allows access to the original timestamps where needed.