Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify qualified name for workflow element icons #1433

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

glopesdev
Copy link
Member

This PR unifies the qualified name syntax for workflow element icons between WorkflowElementIcon and WorkflowNamespaceIcon attributes. The qualified name can now be prefixed with the assembly name in both cases.

The resource qualifier may also be omitted either when providing an assembly name or when an icon matching the full name of the type is already provided by the editor assembly.

@glopesdev glopesdev added the fix Pull request that fixes an issue label Jun 27, 2023
@glopesdev glopesdev added this to the 2.8 milestone Jun 27, 2023
@glopesdev glopesdev merged commit 6fb33d8 into bonsai-rx:main Jun 27, 2023
2 checks passed
@glopesdev glopesdev deleted the simplify-elementicon-declarations branch June 27, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull request that fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant