Avoid deadlock when disposing serial connection #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves concurrency issues around dynamic disposal of serial port connections, especially involving contention and locking inside reactive combinators. The current implementation relies on shared locking of the base stream to implement at-least-once semantics for closing the serial port.
It is unfortunately not ideal in that it does not completely guarantee synchronous disposal of the resource. To do this for all edge-cases would require reimplementing the callback logic in the
SerialPortclass or reimplement the serial port observable using polling via a dedicated service thread.Fixes #1437