test: Add tests, include failure conditions.

[shanecelis]

Hi, Alice invited me to review your PR. I added some tests to check behavior on failure conditions. It all looks good to me.

[bonsairobo]

Thanks for the contribution and review on my PR. I like some of these tests and others not so much. I'm curious what you think about my comments.

[bonsairobo]

This one seems like it's testing Path more than _embedded_asset_path per se. So I generally don't like writing these tests when I know that conditions are handled by the infrastructure I'm using. I'd drop this test.

[shanecelis]

This is one I'd keep partly because it seems surprising to me and someone might think that's desirable behavior. I actually don't understand how a zero-length Path leads to this behavior.

[bonsairobo]

Hmm yea I guess it's odd that this is a functional option. We could add a check that src_path isn't empty.

[bonsairobo]

Does this pass on Windows? I'm not sure when forward slashes are actually allowed.

[shanecelis]

I'm actually very curious about how this will behave on Windows. (I'm on macOS.) I expect everything with a slash will fail actually.

[bonsairobo]

It might be fine. We will find out in CI.

[bonsairobo]

Ditto RE Windows

[shanecelis]

Let's turn these two similar cases into a comment on one test instead of it being two.

[shanecelis]

I think I'll drop this one too. That'll be provided by file!(). I don't think we need to second guess it.

    #[should_panic(expected = "Failed to find src_prefix \"src\" in \"\"")]
    #[test]
    fn embedded_asset_path_from_local_crate_blank_file_path() {
        let asset_path = _embedded_asset_path(
            "my_crate",
            "src".as_ref(),
            "".as_ref(),
            "the/asset.png".as_ref(),
        );
        assert_eq!(asset_path, Path::new("my_crate/foo/the/asset.png"));
    }

[shanecelis]

Thanks for your feedback. Changes incorporated. You're right there was definitely some exploratory programming going on that didn't need to be captured permanently in tests. Thanks for your patience.

[bonsairobo]

Thanks for your feedback. Changes incorporated. You're right there was definitely some exploratory programming going on that didn't need to be captured permanently in tests. Thanks for your patience.

Thanks! No worries, I'm glad you had the mindset of trying to break it.