Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow absolute paths to prover plugins #764

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

atomb
Copy link
Collaborator

@atomb atomb commented Jul 18, 2023

Previously, the /proverDll option allowed only relative paths, since it looked for / or \ within a name, but not at the beginning, to determine whether the given name was a filename or a portion of an internal DLL name. This changes it to also interpret a name as a filename when either of those characters is the first character.

@shazqadeer
Copy link
Contributor

I understand that on a Linux/MacOS machine, a full path starts with /. What is the appropriate way to identify a full path on Windows?

@atomb
Copy link
Collaborator Author

atomb commented Jul 19, 2023

Most full paths on Windows will start with drive names (e.g., c:\dir1\dir2\plugin.dll), and those would already be allowed before this change. However, I believe that Windows paths starting with a backslash are valid, and that network paths are usually formatted that way, so allowing an initial backslash seems worthwhile.

@atomb atomb enabled auto-merge (squash) July 19, 2023 21:57
@atomb atomb merged commit 70d739b into boogie-org:master Jul 20, 2023
4 checks passed
@atomb atomb deleted the prover-plugin-absolute-path branch July 20, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants