This repository has been archived by the owner on May 3, 2022. It is now read-only.
traffic controller: watch Pod events #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdrv
previously approved these changes
Oct 7, 2019
parhamdoustdar
previously approved these changes
Oct 9, 2019
The traffic controller needs to be notified of changes to pods, so it can update the status of TrafficTargets, and make changes to other pods if necessary. Currently, it relies on a resync of the TrafficTarget to trigger any changes to pods that need to receive traffic. If we run shipper without resyncs for long enough, it's possible that pods will die and be re-scheduled without ever receiving traffic again. Now, we apply the same technique we used in the other controllers to watch for events in the application cluster objects.
This prevents weirder to debug issues, as otherwise we'd try to get InstallationTargets and TrafficTargets with the label set to "", and that would obviously fail, with `cannot get installation/traffic target for release 'ns/': not found`. Now we at least point the future debugger to where the problem might be.
juliogreff
force-pushed
the
jgreff/traffic-watch-pods
branch
from
5855e0f
to
2f0e8e9
Compare
parhamdoustdar
approved these changes
Oct 10, 2019
osdrv
approved these changes
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The traffic controller needs to be notified of changes to pods, so it
can update the status of TrafficTargets, and make changes to other pods
if necessary. Currently, it relies on a resync of the TrafficTarget to
trigger any changes to pods that need to receive traffic.
If we run shipper without resyncs for long enough, it's possible that
pods will die and be re-scheduled without ever receiving traffic again.
Now, we apply the same technique we used in the other controllers to
watch for events in the application cluster objects.
This closes #206. Do not that this is not by far the desired end state for the traffic controller, as we still need to implement #23.