This repository has been archived by the owner on May 3, 2022. It is now read-only.
ci: upgrade golang, golangci-lint, microk8s #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliogreff
force-pushed
the
jgreff/ci-updates
branch
from
9a156da
to
1927a0b
Compare
kubectl and golangci-lint should be entirely transparent, so I won't dwell on them too much. The big changes here are: * Move to Go 1.13. I've been running Shipper locally in this version already, so no issues are expected. Since Go 1.13 now validates versions, we had to fix one issue where apimachinery had an invalid timestamp, but no other trouble was found. * Move to microk8s 1.15. We're confident enough that Shipper is stable against 1.14, so let's start trying out a newer version to see how we fare.
juliogreff
force-pushed
the
jgreff/ci-updates
branch
from
1927a0b
to
1ed700d
Compare
juliogreff
changed the title
hihilla
approved these changes
Dec 5, 2019
parhamdoustdar
approved these changes
Dec 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl and golangci-lint should be entirely transparent, so I won't
dwell on them too much.
One big change here is the move to Go 1.13. I've been running Shipper
locally in this version already, so no issues are expected. Since Go 1.13 now validates versions, we had to fix one of those cases as well.
This closes #230.
The other big one is microk8s. We're confident enough that Shipper is stable
against 1.14, so let's start trying out a newer version to see how we fare.