Add a TeamPreMessageEvent and TeamMessageEvent to the API #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose the addition of a TeamPreMessageEvent and TeamMessageEvent to allow third-party developers to more accurately detect, amend and cancel team messages.
This pull request contains the following amendments:
Team#sendMessage(TeamPlayer, String)
by creating the event, providing it with the message components, dispatching the event, parsing all the returned values, and dispatching the team message with those (potentially) modified values.Team#sendMessage(...)
method which dispatches the notification event with the final message and components.The reason for this change comes from a recent plugin I created relating to a chat filter which was forced to use AsyncPlayerChatEvent and PlayerCommandPreprocessEvent to filter and cancel messages, which was not a perfect solution as you may imagine. These events will make the API a lot more future-proof by providing supported events for chat messages rather than having to find workarounds which could be rendered useless if a major plugin update happened.
Happy to hear your thoughts on the new code!