Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds chat prefix to go from global to team or ally chat #545

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

EarthCow
Copy link
Contributor

Adds prefixes to go from the global chat to either the team or ally chat. These prefixes are all configurable and the prefix to go from the team chat or ally chat to the global chat has also been updated to be configurable. Resolves #314

Copy link
Owner

@booksaw booksaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, I have flagged up one issue that may cause some unintended side effects. But apart from that minor thing it looks good :)

@EarthCow EarthCow requested a review from booksaw February 1, 2024 17:03
Copy link
Owner

@booksaw booksaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, this looks great!

@booksaw booksaw merged commit a949af5 into booksaw:master Feb 1, 2024
@EarthCow EarthCow deleted the prefix-chat branch February 1, 2024 17:45
@bobhenl
Copy link

bobhenl commented Feb 24, 2024

Seems it doesn't work with chatcontrolred

@EarthCow
Copy link
Contributor Author

@bobhenl You should be able to change both prefixes in your config file and if you set them to an empty string (i.e. '') it will disable the feature entirely. Let me know if you have any problems though or feel free to open a new issue regarding this.

@bobhenl
Copy link

bobhenl commented Feb 25, 2024

The issue is, when I leave the prefix as default & use them in chat, the message isn't sent into the team chat or ally chat, etc. I guess it's due to ChatControlRed plugin @EarthCow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] A way to chat in team chat by just adding a '!' in ur message (from the general chat)
3 participants