Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SML to Conan-Center #438

Closed
mpusz opened this issue Feb 2, 2021 · 10 comments
Closed

Add SML to Conan-Center #438

mpusz opened this issue Feb 2, 2021 · 10 comments

Comments

@mpusz
Copy link

mpusz commented Feb 2, 2021

Could you please consider adding SML to Conan-Center? It is quite simple: https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md. I can help if needed.

@krzysztof-jusiak
Copy link
Collaborator

Hi @mpusz, oh I'm totally up for it, don't have much experience doing so, though 😞 Any help more than appreicated 🙏 thanks!

@mpusz
Copy link
Author

mpusz commented Feb 2, 2021

Great! 😃
I will add an initial version there but it is you that should provide support for new future library releases. I will provide HowTo instructions here when my changes will be merged into ConanCenter.

@mpusz
Copy link
Author

mpusz commented Feb 16, 2021

It took quite some time to start but I am on it now (conan-io/conan-center-index#4591). The only things to resolve are:

BTW, you can check it by yourself with:

@krzysztof-jusiak
Copy link
Collaborator

Oh, fantastic, thank you @mpusz 🙏

@krzysztof-jusiak
Copy link
Collaborator

Sure, I'll add LINCESE.md

@mpusz
Copy link
Author

mpusz commented Feb 16, 2021

BTW, the build on ConanCenter failed with: conan-io/conan-center-index#4591 (comment) on gcc 4.9. What are the compiler constraints for the library, should I force any specific C++ version standard in CMake?

@mpusz
Copy link
Author

mpusz commented Feb 16, 2021

I forced C++14 and it seems to improve the build. However, now it fails on conan-io/conan-center-index#4591 (comment). We need this license.md and a new release tag that will include this file.

@krzysztof-jusiak
Copy link
Collaborator

Thanks, @mpusz
New release with the LICENSE file https://github.com/boost-ext/sml/releases/tag/v1.1.4

@mpusz
Copy link
Author

mpusz commented Feb 23, 2021

Done! https://conan.io/center/sml 😃

@mpusz mpusz closed this as completed Feb 23, 2021
@krzysztof-jusiak
Copy link
Collaborator

Fantastic, thank you @mpusz 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants