Initial sml version support added #4591

mpusz · 2021-02-16T19:38:46Z

Specify library name and version: sml/1.1.3

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2021-02-16T19:44:50Z

Failure in build 1 (f0b435730c9526501b43027cd6c8f8e076b5ae5e):

sml/1.1.3@:
CI failed to create some packages (All logs)

Logs for packageID 5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++
compiler.version=4.9
os=Linux
os_build=Linux

                     ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:31:24: error: expected namespace-name before ';' token
     using namespace sml;
                        ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:34:21: error: expected ')' before '_s'
       *"established"_s + event<release> / send_fin = "fin wait 1"_s,
                     ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:35:20: error: expected ')' before '_s'
        "fin wait 1"_s + event<ack> [ is_ack_valid ] = "fin wait 2"_s,
                    ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:36:20: error: expected ')' before '_s'
        "fin wait 2"_s + event<fin> [ is_fin_valid ] / send_ack = "timed wait"_s,
                    ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:37:20: error: expected ')' before '_s'
        "timed wait"_s + event<timeout> / send_ack = X
                    ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:38:5: error: 'make_transition_table' was not declared in this scope
     );
     ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp: In function 'int main()':
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:45:19: error: 'sml' is not a namespace-name
   using namespace sml;
                   ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:45:22: error: expected namespace-name before ';' token
   using namespace sml;
                      ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:47:3: error: 'sm' was not declared in this scope
   sm<hello_world> sm;
   ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:47:17: error: expected primary-expression before '>' token
   sm<hello_world> sm;
                 ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:51:27: warning: extended initializer lists only available with -std=c++11 or -std=gnu++11
   sm.process_event(release{});
                           ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:54:23: warning: extended initializer lists only available with -std=c++11 or -std=gnu++11
   sm.process_event(ack{});
                       ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:57:23: warning: extended initializer lists only available with -std=c++11 or -std=gnu++11
   sm.process_event(fin{});
                       ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:60:27: warning: extended initializer lists only available with -std=c++11 or -std=gnu++11
   sm.process_event(timeout{});
                           ^
make[2]: *** [CMakeFiles/test_package.dir/test_package.cpp.o] Error 1
make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
make: *** [all] Error 2
ERROR: sml/1.1.3 (test package): Error in build() method, line 12
	cmake.build()
	ConanException: Error 2 while executing cmake --build '/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/build/dfae4d6ba682b8d9c5630c4c912db585c2a46c64' '--' '-j3'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

conan-center-bot · 2021-02-16T20:03:01Z

Failure in build 2 (849434c6288e18ee242db439992158503f9f307d):

sml/1.1.3@:
CI failed to create some packages (All logs)

Logs for packageID 5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=6
os=Linux
os_build=Linux

********************************************************************************
conan install sml/1.1.3@ --profile=/home/conan/w/BuildSingleReference/5842/ae15546f-76b9-4208-8c26-a3873471238a/profile.txt --build=sml
********************************************************************************
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=6
os=Linux
os_build=Linux
[options]
[build_requires]
[env]

sml/1.1.3: Forced build from source
Installing package: sml/1.1.3
Requirements
    sml/1.1.3 from local cache - Cache
Packages
    sml/1.1.3:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Build

Installing (downloading, building) binaries...
sml/1.1.3: Building your package in /home/conan/w/BuildSingleReference/.conan/data/sml/1.1.3/_/_/build/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9
sml/1.1.3: Generator txt created conanbuildinfo.txt
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not found
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
sml/1.1.3: Calling build()
sml/1.1.3: Package '5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9' built
sml/1.1.3: Build folder /home/conan/w/BuildSingleReference/.conan/data/sml/1.1.3/_/_/build/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9
sml/1.1.3: Generated conaninfo.txt
sml/1.1.3: Generated conanbuildinfo.txt
sml/1.1.3: Generating the package
sml/1.1.3: Package folder /home/conan/w/BuildSingleReference/.conan/data/sml/1.1.3/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9
sml/1.1.3: Calling package()
[HOOK - conan-center.py] post_package(): [DEFAULT PACKAGE LAYOUT (KB-H013)] OK
[HOOK - conan-center.py] post_package(): [MATCHING CONFIGURATION (KB-H014)] OK
[HOOK - conan-center.py] post_package(): [SHARED ARTIFACTS (KB-H015)] OK
[HOOK - conan-center.py] post_package(): [PC-FILES (KB-H020)] OK
[HOOK - conan-center.py] post_package(): [CMAKE-MODULES-CONFIG-FILES (KB-H016)] OK
[HOOK - conan-center.py] post_package(): [PDB FILES NOT ALLOWED (KB-H017)] OK
[HOOK - conan-center.py] post_package(): [LIBTOOL FILES PRESENCE (KB-H018)] OK
[HOOK - conan-center.py] post_package(): [MS RUNTIME FILES (KB-H021)] OK
sml/1.1.3: WARN: This conanfile has no build step
[HOOK - conan-center.py] post_package(): ERROR: [PACKAGE LICENSE (KB-H012)] No 'licenses' folder found in package: /home/conan/w/BuildSingleReference/.conan/data/sml/1.1.3/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9  (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H012) 
ERROR: [HOOK - conan-center.py] post_package(): Some checks failed running the hook, check the output

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

krzysztof-jusiak · 2021-02-16T20:55:16Z

@mpusz Added the license https://github.com/boost-ext/sml/blob/master/LICENSE.md

SpaceIm · 2021-02-16T21:41:58Z

recipes/sml/all/conanfile.py

+        return "build_subfolder"
+
+    def validate(self):
+        check_min_cppstd(self, "14")


It prevents to consume sml if default standard of the compiler is not 14 or above, and compiler.cppstd not explictly set. I think that it also raises if compiler is not mainstream.
You can use this kind of pattern instead (with some adjustments on min compilers versions):

conan-center-index/recipes/capnproto/all/conanfile.py

Lines 41 to 48 in d7e0581

@property

def _minimum_compilers_version(self):

return {

"Visual Studio": "15",

"gcc": "5",

"clang": "5",

"apple-clang": "5.1",

}

conan-center-index/recipes/capnproto/all/conanfile.py

Lines 57 to 63 in d7e0581

if self.settings.compiler.cppstd:

tools.check_min_cppstd(self, 14)

minimum_version = self._minimum_compilers_version.get(str(self.settings.compiler), False)

if not minimum_version:

self.output.warn("Cap'n Proto requires C++14. Your compiler is unknown. Assuming it supports C++14.")

elif tools.Version(self.settings.compiler.version) < minimum_version:

raise ConanInvalidConfiguration("Cap'n Proto requires C++14, which your compiler does not support.")

I am not sure how it helps here? The only issue with my usage of check_min_cppstd(self, "14") is that it might not work for some strange niche compiler and the user will be forced to set cppstd for it explicitly. This eventually makes it work for any compiler.

Adding the rest of the suggested code does not help here as tools.check_min_cppstd(self, 14) will throw an Exception for an unknown compiler anyway so the rest of the code will not be executed, right?

It allows to use the recipe even if cppstd (which is an experimental feature) is not set.
If you look at https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/4591/2/sml/1.1.3//summary.json, it throws for all apple-clang versions tested in CI.

The suggested code:

throws if cppstd < 14 is explicitly requested

throws if cppstd is not set or >= 14, and the compiler version in profile is known for not supporting C++14

displays a warning if cppstd is not set or >= 14, and we don't know if the compiler supports C++14

I do not think that we should verify the C++ standard version based on the compiler's version. If this is the case we need a better utility in Conan tools. It is just too verbose and error-prone.

But if you prefer, I can rename validate to configure (this change will probably be reverted for Conan 2.0 later on) and add if self.settings.compiler.get_safe("cppstd"):.

Learned this the hard way ;-) I think that now everything is fine?

For my tracking purposes conan-io/conan#8002

Please follow the suggestions above, this is a requirement because of a technical limitation of CCI... so for now we need to make sure this is merged in.

Thanks for understanding 😄

Sure, I changed to configure() usage 4 days ago.

Yes but you have to implement the full solution proposed above (with explicit compiler versions).

recipes/sml/all/conanfile.py

conan-center-bot · 2021-02-17T08:34:05Z

Failure in build 3 (009388b1de45a383ed834a76afe383a3c418a0ac):

sml/1.1.3@:
Error running command 'conan export "recipes/sml/all/conanfile.py" sml/1.1.3@':

[HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
[HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
[HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
[HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
[HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 4.2890625 KB
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
[HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
[HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
[HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
[HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
[HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
[HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
[HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
[HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
[HOOK - conan-center.py] pre_export(): [NO ASCII CHARACTERS (KB-H047)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
[HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
[HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
[HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "1.1.4" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "1.1.4". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052) 
ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

conan-center-bot · 2021-02-17T09:15:42Z

All green in build 4 (4dcd9dc6d43b529543880e01bfe86768e9dc82d8):

sml/1.1.4@:
All packages built successfully! (All logs)

krzysztof-jusiak · 2021-02-17T11:53:55Z

@SpaceIm, @mpusz Double confirm that SML has no dependencies neither Boost nor STL

…added

conan-center-bot · 2021-02-17T15:14:00Z

Failure in build 5 (2367046cd03bce84dd03ca49c816eed277b8c56c):

sml/1.1.4@:
CI failed to create some packages (All logs)

Logs for packageID 5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++
compiler.version=4.9
os=Linux
os_build=Linux

                                  ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:36:38: warning: capture of variable '{anonymous}::is_fin_valid' with non-automatic storage duration
        "fin wait 2"_s + event<fin> [ is_fin_valid ] / send_ack = "timed wait"_s,
                                      ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:22:12: note: 'const {anonymous}::<lambda(const {anonymous}::fin&)> {anonymous}::is_fin_valid' declared here
 const auto is_fin_valid = [](const fin&) { return true; };
            ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp: In lambda function:
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:36:53: error: expected '{' before '/' token
        "fin wait 2"_s + event<fin> [ is_fin_valid ] / send_ack = "timed wait"_s,
                                                     ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp: In member function 'auto {anonymous}::hello_world::operator()() const':
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:36:53: error: no match for 'operator/' (operand types are '{anonymous}::hello_world::operator()() const::<lambda()>' and 'const {anonymous}::<lambda()>')
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:36:66: error: unable to find string literal operator 'operator""_s'
        "fin wait 2"_s + event<fin> [ is_fin_valid ] / send_ack = "timed wait"_s,
                                                                  ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:37:8: error: unable to find string literal operator 'operator""_s'
        "timed wait"_s + event<timeout> / send_ack = X
        ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:37:38: error: expected primary-expression before '>' token
        "timed wait"_s + event<timeout> / send_ack = X
                                      ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:37:40: error: expected primary-expression before '/' token
        "timed wait"_s + event<timeout> / send_ack = X
                                        ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:37:53: error: 'X' was not declared in this scope
        "timed wait"_s + event<timeout> / send_ack = X
                                                     ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:38:5: error: 'make_transition_table' was not declared in this scope
     );
     ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp: In function 'int main()':
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:45:19: error: 'sml' is not a namespace-name
   using namespace sml;
                   ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:45:22: error: expected namespace-name before ';' token
   using namespace sml;
                      ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:47:3: error: 'sm' was not declared in this scope
   sm<hello_world> sm;
   ^
/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/test_package.cpp:47:17: error: expected primary-expression before '>' token
   sm<hello_world> sm;
                 ^
make[2]: *** [CMakeFiles/test_package.dir/test_package.cpp.o] Error 1
make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
make: *** [all] Error 2
ERROR: sml/1.1.4 (test package): Error in build() method, line 12
	cmake.build()
	ConanException: Error 2 while executing cmake --build '/home/conan/w/BuildSingleReference/conan-center-index/recipes/sml/all/test_package/build/dfae4d6ba682b8d9c5630c4c912db585c2a46c64' '--' '-j3'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

conan-center-bot · 2021-02-17T15:37:08Z

All green in build 6 (45b3d316a1ed0264e7c6504b4bfa83d1c18e8393):

sml/1.1.4@:
All packages built successfully! (All logs)

krzysztof-jusiak · 2021-02-19T15:13:30Z

Hi,
Just wanted to ensure that the package name will be called sml and won't have boost in it, please.
Thank, you

recipes/sml/all/conanfile.py

prince-chrismc · 2021-02-21T02:07:10Z

recipes/sml/all/conanfile.py

+        return "build_subfolder"
+
+    def validate(self):
+        check_min_cppstd(self, "14")


Please follow the suggestions above, this is a requirement because of a technical limitation of CCI... so for now we need to make sure this is merged in.

Thanks for understanding 😄

recipes/sml/all/test_package/test_package.cpp

prince-chrismc · 2021-02-21T02:10:37Z

recipes/sml/all/test_package/test_package.cpp

+#include <boost/sml.hpp>
+#include <cassert>
+
+namespace sml = boost::sml;


https://github.com/conan-io/conan-center-index/blob/master/docs/reviewing.md#minimalistic-source-code

Is there any way we can make a cross platform test package? it does not need to do anything just use those headers should be sufficient?

@krzysztof-jusiak, could you please share a simpler cross-platform test example?

prince-chrismc

Misclicked.

Co-authored-by: Chris Mc <[email protected]>

conan-center-bot · 2021-02-21T09:37:19Z

Failure in build 7 (641306242dd825525e052ebbae57e7c55956a923):

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2021-02-21T09:46:03Z

All green in build 8 (04fb290a6f685da63c7e97472ee3e234d5b67a37):

sml/1.1.4@:
All packages built successfully! (All logs)

…o sml

conan-center-bot · 2021-02-21T09:51:00Z

Failure in build 9 (3db036f14a9880f1221fbfd4394367fb1efb83ee):

sml/1.1.4@:
Error running command 'conan export "recipes/sml/all/conanfile.py" sml/1.1.4@':

ERROR: Error loading conanfile at '/home/conan/w/cci_PR-4591/recipes/sml/all/conanfile.py': Unable to load conanfile in /home/conan/w/cci_PR-4591/recipes/sml/all/conanfile.py
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/imp.py", line 171, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 724, in exec_module
  File "<frozen importlib._bootstrap_external>", line 860, in get_code
  File "<frozen importlib._bootstrap_external>", line 791, in source_to_code
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/cci_PR-4591/recipes/sml/all/conanfile.py", line 26
    return {
         ^
IndentationError: expected an indented block

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

conan-center-bot · 2021-02-21T10:25:39Z

Failure in build 10 (1657c89037ebcb4e98aee19a1b1c8c9c3fab44d1):

sml/1.1.4@:
Error running command 'conan info sml/1.1.4@ --json {jsonName} -pr {profileName}':

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++
compiler.version=4.9
os=Linux
os_build=Linux

...
ERROR: sml/1.1.4: Error in configure() method, line 40
	raise ConanInvalidConfiguration("SML requires C++14, which your compiler does not support.")
	NameError: name 'ConanInvalidConfiguration' is not defined

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

conan-center-bot · 2021-02-21T11:17:15Z

All green in build 11 (e92a2a3966ddc54e9776a5ab2bf68048bb0eb226):

sml/1.1.4@:
All packages built successfully! (All logs)

recipes/sml/all/conanfile.py

Co-authored-by: SpaceIm <[email protected]>

conan-center-bot · 2021-02-21T12:36:12Z

All green in build 12 (4c136c96b6c04f7c3978988110055c5b294561c7):

sml/1.1.4@:
All packages built successfully! (All logs)

SpaceIm · 2021-02-21T19:13:15Z

@krzysztof-jusiak Could you explain why this recipe can't be prefixed with boost-ext- like boost-ex-ut recipe? I saw that you asked to rename this recipe also #4617

krzysztof-jusiak · 2021-02-21T19:41:37Z

It's to avoid confusion with official boost libraries. It's advised not to use boost name in the user-facing packages until the review/acceptance will happen.

Initial sml version support added

f0b4357

conan-center-bot added the Failed label Feb 16, 2021

mpusz mentioned this pull request Feb 16, 2021

Add SML to Conan-Center boost-ext/sml#438

Closed

C++14 requirement set for SML

849434c

SpaceIm reviewed Feb 16, 2021

View reviewed changes

SML bumped to 1.1.4

009388b

Forgot to change the version in the config.yml as well

4dcd9dc

conan-center-bot removed the Failed label Feb 17, 2021

validate() renamed to configure() and get_safe("cppstd") check …

2367046

…added

mpusz marked this pull request as ready for review February 17, 2021 15:09

conan-center-bot added the Failed label Feb 17, 2021

Got rid of get_safe(cppstd)

45b3d31

conan-center-bot removed the Failed label Feb 17, 2021

prince-chrismc approved these changes Feb 21, 2021

View reviewed changes

prince-chrismc suggested changes Feb 21, 2021

View reviewed changes

SSE4 requested a review from uilianries February 21, 2021 05:28

mpusz and others added 2 commits February 21, 2021 10:35

Update recipes/sml/all/conanfile.py

6413062

Co-authored-by: Chris Mc <[email protected]>

Update recipes/sml/all/test_package/test_package.cpp

04fb290

Co-authored-by: Chris Mc <[email protected]>

conan-center-bot added the Unexpected Error label Feb 21, 2021

conan-center-bot removed the Unexpected Error label Feb 21, 2021

mpusz added 2 commits February 21, 2021 10:49

_minimum_compilers_version added

2585a45

Merge branch 'sml' of https://github.com/mpusz/conan-center-index int…

3db036f

…o sml

conan-center-bot added the Failed label Feb 21, 2021

Indentation fixed

1657c89

ConanInvalidConfiguration import added

e92a2a3

conan-center-bot removed the Failed label Feb 21, 2021

SpaceIm reviewed Feb 21, 2021

View reviewed changes

recipes/sml/all/conanfile.py Outdated Show resolved Hide resolved

Update recipes/sml/all/conanfile.py

4c136c9

Co-authored-by: SpaceIm <[email protected]>

prince-chrismc approved these changes Feb 21, 2021

View reviewed changes

github-actions bot mentioned this pull request Feb 21, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

uilianries approved these changes Feb 22, 2021

View reviewed changes

SpaceIm approved these changes Feb 22, 2021

View reviewed changes

conan-center-bot merged commit ef15672 into conan-io:master Feb 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial sml version support added #4591

Initial sml version support added #4591

mpusz commented Feb 16, 2021

conan-center-bot commented Feb 16, 2021

conan-center-bot commented Feb 16, 2021

krzysztof-jusiak commented Feb 16, 2021

SpaceIm Feb 16, 2021 •

edited

Loading

mpusz Feb 17, 2021

SpaceIm Feb 17, 2021 •

edited

Loading

mpusz Feb 17, 2021

mpusz Feb 17, 2021

mpusz Feb 17, 2021

prince-chrismc Feb 21, 2021

prince-chrismc Feb 21, 2021

mpusz Feb 21, 2021

SpaceIm Feb 21, 2021

conan-center-bot commented Feb 17, 2021

conan-center-bot commented Feb 17, 2021

krzysztof-jusiak commented Feb 17, 2021

conan-center-bot commented Feb 17, 2021

conan-center-bot commented Feb 17, 2021

krzysztof-jusiak commented Feb 19, 2021

prince-chrismc Feb 21, 2021

prince-chrismc Feb 21, 2021

mpusz Feb 21, 2021

prince-chrismc left a comment

conan-center-bot commented Feb 21, 2021

conan-center-bot commented Feb 21, 2021

conan-center-bot commented Feb 21, 2021

conan-center-bot commented Feb 21, 2021

conan-center-bot commented Feb 21, 2021

conan-center-bot commented Feb 21, 2021

SpaceIm commented Feb 21, 2021 •

edited

Loading

krzysztof-jusiak commented Feb 21, 2021

	@property
	def _minimum_compilers_version(self):
	return {
	"Visual Studio": "15",
	"gcc": "5",
	"clang": "5",
	"apple-clang": "5.1",
	}

	if self.settings.compiler.cppstd:
	tools.check_min_cppstd(self, 14)
	minimum_version = self._minimum_compilers_version.get(str(self.settings.compiler), False)
	if not minimum_version:
	self.output.warn("Cap'n Proto requires C++14. Your compiler is unknown. Assuming it supports C++14.")
	elif tools.Version(self.settings.compiler.version) < minimum_version:
	raise ConanInvalidConfiguration("Cap'n Proto requires C++14, which your compiler does not support.")

Initial sml version support added #4591

Initial sml version support added #4591

Conversation

mpusz commented Feb 16, 2021

conan-center-bot commented Feb 16, 2021

conan-center-bot commented Feb 16, 2021

krzysztof-jusiak commented Feb 16, 2021

SpaceIm Feb 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm Feb 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Feb 17, 2021

conan-center-bot commented Feb 17, 2021

krzysztof-jusiak commented Feb 17, 2021

conan-center-bot commented Feb 17, 2021

conan-center-bot commented Feb 17, 2021

krzysztof-jusiak commented Feb 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prince-chrismc left a comment

Choose a reason for hiding this comment

conan-center-bot commented Feb 21, 2021

conan-center-bot commented Feb 21, 2021

conan-center-bot commented Feb 21, 2021

conan-center-bot commented Feb 21, 2021

conan-center-bot commented Feb 21, 2021

conan-center-bot commented Feb 21, 2021

SpaceIm commented Feb 21, 2021 • edited Loading

krzysztof-jusiak commented Feb 21, 2021

SpaceIm Feb 16, 2021 •

edited

Loading

SpaceIm Feb 17, 2021 •

edited

Loading

SpaceIm commented Feb 21, 2021 •

edited

Loading