Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refact] Refactoring code & Add docstring #92

Merged
merged 1 commit into from
Jun 9, 2022
Merged

[Refact] Refactoring code & Add docstring #92

merged 1 commit into from
Jun 9, 2022

Conversation

sooya233
Copy link
Contributor

@sooya233 sooya233 commented Jun 9, 2022

기능 설명

  • Docstring을 이용하여 api에 대한 설명을 작성.
  • 전반적인 print문과 같은 상관없는 코드 제거

Key Changes

  • modified: serving/backend/app/api/face.py
  • modified: serving/backend/app/api/video.py
  • modified: serving/backend/app/ml/face_functions.py
  • modified: serving/backend/app/ml/final_shorts/final_timeline.py
  • modified: serving/backend/app/ml/final_shorts/make_shorts.py
  • modified: serving/backend/app_laughter/ml/laughter_detection.py

Related Issue

close #91

@sooya233
[Refact] Refactoring code & Add docstring
660779d 
- Docstring을 이용하여 api에 대한 설명을 작성.
- 코드 리팩토링 진행
issue #91
@sooya233 sooya233 added the BE Serving 중 Backend 관련 이슈 label Jun 9, 2022
@sooya233 sooya233 requested a review from seungriyou June 9, 2022 08:15
@sooya233 sooya233 self-assigned this Jun 9, 2022
seungriyou
seungriyou approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@seungriyou seungriyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 LGTM 🌟
파일 맨 마지막에 빈 줄을 띄워주지 않으면 github 상에서는 빨간색 경고가 뜨는데, 이건 나중에 다른 툴을 이용해서 일괄적으로 적용 가능할 것 같습니다! 감사합니다~~

@seungriyou seungriyou merged commit 3c5f7a4 into develop Jun 9, 2022
@seungriyou seungriyou deleted the refact/91 branch June 9, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seungriyou seungriyou seungriyou approved these changes

Assignees

@sooya233 sooya233

Labels
BE Serving 중 Backend 관련 이슈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sooya233 @seungriyou