Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refact] Refactoring FrontEnd #94

Merged
merged 1 commit into from
Jun 9, 2022
Merged

[Refact] Refactoring FrontEnd #94

merged 1 commit into from
Jun 9, 2022

Conversation

sooya233
Copy link
Contributor

@sooya233 sooya233 commented Jun 9, 2022

기능 설명

  • FrontEnd에서 실제 서비스에 필요하지 않은 코드들을 삭제하였다.

Key Changes

  • modified: serving/frontend/src/App.js
  • modified: serving/frontend/src/components/PeoplePanel.js
  • modified: serving/frontend/src/pages/SelectPerson.js
  • modified: serving/frontend/src/pages/SelectVideo.js
  • modified: serving/frontend/src/pages/UploadVideo.js

Related Issue

close #93

@sooya233
[Refact] Refactoring FrontEnd
74844a1 
- FrontEnd에서 실제 서비스에 필요하지 않은 코드들을 삭제하였다.
issue #93
@sooya233 sooya233 added the FE Serving 중 Frontend 관련 이슈 label Jun 9, 2022
@sooya233 sooya233 requested a review from seungriyou June 9, 2022 10:32
@sooya233 sooya233 self-assigned this Jun 9, 2022
seungriyou
seungriyou approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@seungriyou seungriyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@seungriyou seungriyou merged commit f3ef502 into develop Jun 9, 2022
@seungriyou seungriyou deleted the refact/93 branch June 9, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seungriyou seungriyou seungriyou approved these changes

Assignees

@sooya233 sooya233

Labels
FE Serving 중 Frontend 관련 이슈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sooya233 @seungriyou