Refact/231207 new question focus #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존: 5가지 색으로 인덱스에 따라 색 지정 - 개선: 리스트에 생성되는 메모지의 색을 노란색으로 고정해 화이트보드에 생성되는 메모지의 색과 일치시켰습니다.
✅ Deploy Preview for boarlog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LellowMellow
approved these changes
Dec 7, 2023
| }, []); | ||
| if (type === "prompt") { | ||
| useEffect(() => { | ||
| console.log("p"); |
There was a problem hiding this comment.
특별한 의미가 있는 console.log가 아니라면 지워주셔도 좋을 것 같습니다!
| if (type === "prompt") { | ||
| useEffect(() => { | ||
| console.log("p"); | ||
| axios("./reviewLecture.json") |
There was a problem hiding this comment.
미리 mock 데이터로 API 요청 대신하신 점 너무 좋습니다.
Comment on lines
+1
to
+18
| const MS_OF_SECOND = 1000; | ||
| const SECOND_OF_HOUR = 3600; | ||
| const MINUTE_OF_HOUR = 60; | ||
|
|
||
| const convertMsToTimeString = (ms: string) => { | ||
| let msNumber = parseInt(ms); | ||
| let seconds = Math.floor(msNumber / MS_OF_SECOND); | ||
| let hours = Math.floor(seconds / SECOND_OF_HOUR); | ||
| seconds = seconds % 3600; | ||
|
|
||
| let minutes = Math.floor(seconds / MINUTE_OF_HOUR); | ||
| seconds = seconds % 60; | ||
|
|
||
| return `${hours.toString().padStart(2, "0")}:${minutes.toString().padStart(2, "0")}:${seconds | ||
| .toString() | ||
| .padStart(2, "0")}`; | ||
| }; | ||
| export default convertMsToTimeString; |
There was a problem hiding this comment.
헉..! 바로 반영해주셨군요,,,! 감사합니다 :)
Jw705
approved these changes
Dec 7, 2023
|
|
||
| return COLOR_SET[randomIndex].background + " " + COLOR_SET[randomIndex].border; | ||
| }; | ||
| const MEMO_COLOR = "bg-memo-yellow border-memo-border-yellow"; |
Comment on lines
+1
to
+18
| const MS_OF_SECOND = 1000; | ||
| const SECOND_OF_HOUR = 3600; | ||
| const MINUTE_OF_HOUR = 60; | ||
|
|
||
| const convertMsToTimeString = (ms: string) => { | ||
| let msNumber = parseInt(ms); | ||
| let seconds = Math.floor(msNumber / MS_OF_SECOND); | ||
| let hours = Math.floor(seconds / SECOND_OF_HOUR); | ||
| seconds = seconds % 3600; | ||
|
|
||
| let minutes = Math.floor(seconds / MINUTE_OF_HOUR); | ||
| seconds = seconds % 60; | ||
|
|
||
| return `${hours.toString().padStart(2, "0")}:${minutes.toString().padStart(2, "0")}:${seconds | ||
| .toString() | ||
| .padStart(2, "0")}`; | ||
| }; | ||
| export default convertMsToTimeString; |
There was a problem hiding this comment.
util 폴더 분리 너무 좋네요! 저도 잘 사용하겠습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 개요
질문리스트, 질문 채팅 관련 사용성 개선
작업 사항
발표자-질문리스트 새로운 질문 상단에 생성 Refactor: 참여자, 발표자 최신 질문에 대한 사용성 개선 #216
발표자-버블의 알림 애니메이션이 헤더 밑으로 깔리는 문제 해결
참여자-질문 채팅 새로운 질문으로 스크롤 이동 Refactor: 참여자, 발표자 최신 질문에 대한 사용성 개선 #216
고민한 점들(필수 X)
스크린샷(필수 X)
2023-12-07.4.34.15.mov
2023-12-07.4.48.40.mov
2023-12-07.4.35.34.mov
2023-12-07.4.49.25.mov
2023-12-07.4.36.43.mov
2023-12-07.4.37.41.mov