Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make boost::iostreams::detail::path constructible from std::filesystem::path #110

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Make boost::iostreams::detail::path constructible from std::filesystem::path #110

wants to merge 7 commits into from

Conversation

nikola-sh
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #110 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #110   +/-   ##
========================================
  Coverage    68.84%   68.84%           
========================================
  Files           80       80           
  Lines         3444     3444           
  Branches      1027     1027           
========================================
  Hits          2371     2371           
  Misses         454      454           
  Partials       619      619
Impacted Files Coverage Δ
include/boost/iostreams/detail/path.hpp 77.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc86890...126d851. Read the comment docs.

@nikola-sh
Copy link
Author

@jeking3 Take a look at this PR please

@nikola-sh
Copy link
Author

@mclow Take a look at this PR please

@mclow
Copy link
Contributor

mclow commented May 18, 2020

I don't see any tests for this new functionality. The code looks reasonable, but w/o tests, do we know that it works?

@nikola-sh nikola-sh marked this pull request as draft May 19, 2020 14:14
@nikola-sh nikola-sh marked this pull request as ready for review May 19, 2020 16:34
nikola-sh
nikola-sh commented May 19, 2020
View reviewed changes
test/Jamfile.v2
[ test-iostreams
path_test.cpp
: [ check-target-builds ../../config/checks//cpp_lib_filesystem
: [ check-target-builds can_use_stdcxxfs : <source>stdc++fs : [ check-target-builds can_use_cxxfs : <source>c++fs ] ]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

early gcc and clang versions requires to link specific filesystem library

@nikola-sh
Copy link
Author

@mclow I have added a test.
PR is failed because one job is failed with error Error: retrieving gpg key timed out. Could you review a code and rerun failed job?

@nikola-sh
Copy link
Author

@mclow Take a look at this PR again please

@marcrambo marcrambo mentioned this pull request Mar 29, 2021
Open
@timblechmann
Copy link
Contributor

any update on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikola-sh @mclow @timblechmann