Fix errors on screenshots #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run step if failure Set working directory Quote message Debuggin Check first, man With name and email Changed in CI Please review changes in these files carefully, as they were automatically generated during CI. Revert "Changed in CI" This reverts commit 1bf997c. Add documentation and cleanups Fix quoting
Please review the changes in the files in this commit carefully, as they were automatically generated during CI. Run `git pull` to bring the changes into your local branch. Then, if you do not want the changes, run `git revert HEAD`.
This reverts commit e4f9d01.
Please review the changes in the files in this commit carefully, as they were automatically generated during CI. Run `git pull` to bring the changes into your local branch. Then, if you do not want the changes, run `git revert HEAD`.
lcreid
force-pushed
the
fix-errors-on-screenshots
branch
from
1bc8bb6
to
40a7b0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we were generating the screenshots for the
errors_onexamples didn't have the right markup to cause the errors to be displayed.Branched from #715 . There will be fewer changes in this PR once that one is merged.
Fixes: #714 .