Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

borg with-lock does not refresh the lock #8347

Closed
ThomasWaldmann opened this issue Aug 31, 2024 · 1 comment
Closed

borg with-lock does not refresh the lock #8347

ThomasWaldmann opened this issue Aug 31, 2024 · 1 comment
Assignees
@ThomasWaldmann
Milestone
2.0.0b10

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Aug 31, 2024 •
edited
Loading

Bug in #8332: similar to what I discovered for #6020, borg with-lock command has in issue, because currently no one refreshes that lock:

  • the lock would auto-expire after 30mins if not refreshed
  • at least the borg with-lock parent process keeps running, so another borg process won't kill the lock due to a dead owner process.
@ThomasWaldmann ThomasWaldmann added this to the 2.0.0b10 milestone Aug 31, 2024
@ThomasWaldmann
Copy link
Member Author

Possible solutions:

  • lock-refreshing background subprocess; start it, terminate it
  • run the subcommand as background subprocess and refresh the lock in the parent process.

@ThomasWaldmann ThomasWaldmann self-assigned this Aug 31, 2024
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Aug 31, 2024
@ThomasWaldmann
with-lock: refresh repo lock while subprocess is running, fixes borgb…
81c2f2b 
…ackup#8347

otherwise the lock might become stale and could get
killed by any other borg process.

note: ThreadRunner class written by PyCharm AI and
only needed small enhancements. nice.
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Aug 31, 2024
@ThomasWaldmann
with-lock: refresh repo lock while subprocess is running, fixes borgb…
66c2999 
…ackup#8347

otherwise the lock might become stale and could get
killed by any other borg process.

note: ThreadRunner class written by PyCharm AI and
only needed small enhancements. nice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasWaldmann ThomasWaldmann

Labels
None yet
Projects
None yet
Milestone
2.0.0b10
Development

No branches or pull requests
1 participant
@ThomasWaldmann