Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression problem #13

Closed
dellaert opened this issue May 20, 2019 · 2 comments
Closed

Expression problem #13

dellaert opened this issue May 20, 2019 · 2 comments
Assignees
Labels
enhancement Improvement to GTSAM help wanted Need help and/or clarification

Comments

@dellaert
Copy link
Member

Address Brice's compile problems (reported in Google groups) by patching slam/expressions.h like so:

namespace internal {
Rot3 rotation(const Pose3& pose, OptionalJacobian<3, 6> H) {
  return pose.rotation(H);
}
}  // namespace internal

inline Rot3_ rotation(const Pose3_& pose) { return Rot3_(internal::rotation, pose); }

TEST(SlamExpressions, rotation) {
  Pose3_ T_(0);
  const Rot3_ R_ = rotation(T_);
}

/* ************************************************************************* */
TEST(SlamExpressions, unrotate) {
  Rot3_ R_(0);
  Point3_ p_(1);
  const Point3_ q_ = unrotate(R_, p_);
}

@dellaert dellaert added the enhancement Improvement to GTSAM label May 20, 2019
@dellaert dellaert self-assigned this May 20, 2019
@dellaert dellaert added the help wanted Need help and/or clarification label May 21, 2019
@dellaert
Copy link
Member Author

Brice, submit a PR with your solution?

@dellaert
Copy link
Member Author

Fixed in PR #18

varunagrawal added a commit that referenced this issue Dec 10, 2020
20e8e8b Merge pull request #11 from borglab/feature/package
04b844b use new version of FindPython and be consistent
3f9d7a3 Merge pull request #13 from borglab/add_license
c791075 Add LICENSE
517b67c correct working directory for setup.py
1b22b47 move matlab.h to root directory
37b4072 Proper source directory path for use in other projects
61696dd configure PybindWrap within the cmake directory
1b91fc9 add config file so we can use find_package
a1e6f4f small typo
da9f351 updated README and housekeeping
64b8f78 files needed to allow for packaging
bddda7f package structure

git-subtree-dir: wrap
git-subtree-split: 20e8e8b7a80e0eed9a38971dde031ade5a595112
varunagrawal added a commit that referenced this issue Jan 4, 2021
09f8bbf71 Merge pull request #25 from borglab/fix/function-name
0dbfb6c13 fix function name to be the correct one
f69f8b01f Merge pull request #24 from borglab/fix/pip
6519a6627 use pip install to overcome superuser issues
b11ecf4e8 Merge pull request #23 from borglab/fix/remove-pip-args
813030108 remove pip-args since we are using setup.py
498d233e0 Merge pull request #22 from borglab/fix/package-install
846212ac3 set correct flags for installing gtwrap package
62161cd20 Merge pull request #21 from borglab/feature/script-vars
93be1d9f8 set script variables and move pybind11 loading so gtwrap can be used under gtsam
8770e3c7e Merge pull request #20 from borglab/fix/pybind-include
8c3c83618 proper placement of pybind11 include
a9ad4f504 Merge pull request #19 from borglab/feature/package
99d8a12c7 added more documentation
4cbec1579 change to macro so we don't have to deal with function scopes
b83e405b8 updates to completely install the package
38a64b3de new scripts which will be installed to bin directory
bf9646235 Merge pull request #18 from borglab/fix/cmake-min
c7c280099 Consistent cmake minimum required
42df58f62 Merge pull request #17 from borglab/fix/cleanup
e580b282d version bump
4ccd66fa5 More finegrained handling of Python version
6476fd710 Merge pull request #16 from borglab/feature/better-find-python
8ac1296a0 use setup.py to install dependencies
e9ac473be install dependencies and support versions of CMake<3.12
cf272dbd2 Merge pull request #15 from borglab/feature/utils
ffc9cc4f7 new utils to reduce boilerplate
20e8e8b7a Merge pull request #11 from borglab/feature/package
04b844bd6 use new version of FindPython and be consistent
3f9d7a32a Merge pull request #13 from borglab/add_license
c791075a6 Add LICENSE
517b67c46 correct working directory for setup.py
1b22b47ae move matlab.h to root directory
37b407214 Proper source directory path for use in other projects
61696dd5d configure PybindWrap within the cmake directory
1b91fc9af add config file so we can use find_package
a1e6f4f53 small typo
da9f351be updated README and housekeeping
64b8f78d5 files needed to allow for packaging
bddda7f54 package structure

git-subtree-dir: wrap
git-subtree-split: 09f8bbf7172ba8b1bd3d2484795743f16e1a5893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to GTSAM help wanted Need help and/or clarification
Projects
None yet
Development

No branches or pull requests

1 participant