TBB Deprecation Warnings

[acxz]

Description

TBB has been updated and now when building gtsam the build output is cluttered with deprecation warnings.

[ 42%] Building CXX object gtsam/CMakeFiles/gtsam.dir/symbolic/SymbolicEliminationTree.cpp.o
In file included from /home/acxz/vcs/git/github/acxz/gtsam/gtsam/base/treeTraversal/parallelTraversalTasks.h:25,
                 from /home/acxz/vcs/git/github/acxz/gtsam/gtsam/base/treeTraversal-inst.h:19,
                 from /home/acxz/vcs/git/github/acxz/gtsam/gtsam/inference/EliminationTree-inst.h:25,
                 from /home/acxz/vcs/git/github/acxz/gtsam/gtsam/symbolic/SymbolicEliminationTree.cpp:19:
/usr/include/tbb/task.h:21:139: note: #pragma message: TBB Warning: tbb/task.h is deprecated. For details, please see Deprecated Features appendix in the TBB reference manual.
   21 | #pragma message("TBB Warning: tbb/task.h is deprecated. For details, please see Deprecated Features appendix in the TBB reference manual.")
      |                                                                                                                                           ^

Steps to reproduce

1. git clone https://github.com/borglab/gtsam
2. mkdir build && cd build && cmake .. && make

Expected behavior

No TBB deprecation warnings.

Environment

OS: ArchLinux
GTSAM version: latest develop branch (7ebfdad) at time of posting
TBB version: 2020.2

Additional information

Some helpful information on fixing this issue: oneapi-src/oneTBB#243

[acxz]

Focal Fossa (the latest LTS version of Ubuntu) will be released on Apr 23rd see

The TBB version it will ship with is 2020.1 see
This will cause warnings that showed up in other distros like Arch to show up in Ubuntu.

If #209 still requires a longer time to review, can we bandaid the issue by suppressing the TBB warnings in the GTSAM code.

[ruffsl]

These deprecation warnings are getting spamy in my Ubuntu 20.04 build logs. It'd be nice to see #209 merged so we don't have to monkey patch other cmake projects that have drowned out warnings.

[dellaert]

These deprecation warnings are getting spamy in my Ubuntu 20.04 build logs. It'd be nice to see #209 merged so we don't have to monkey patch other cmake projects that have drowned out warnings.

@ruffsl can you confirm #209 works for you as expected, and both TBB and non-TBB compile and run as expected?

[acxz]

@ruffsl the warnings up to TBB 2020.1 (shipped with Latest-LTS Ubuntu) should be gone (develop branch), there are still deprecation warnings with TBB 2020.2 that need to be addressed. Particularly the deprecation of task.h.

[ruffsl]

Thanks @acxz , the downstream build logs are a quieter:

--- stderr: gtsam
/opt/ros/underlay_ws/src/borglab/gtsam/gtsam/3rdparty/CCOLAMD/Source/ccolamd.c: In function ‘ccolamd2’:
/opt/ros/underlay_ws/src/borglab/gtsam/gtsam/3rdparty/CCOLAMD/Source/ccolamd.c:1563:9: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
 1563 |     Int cs ;
      |         ^~
---

Although, I only tested it with TBB enabled as thats what my project also needs to run.

[acxz]

Glad to hear that, that specific warning is due to CCOLAMD which is a 3rd party codebase. Should be resolved with DrTimothyAldenDavis/SuiteSparse#39

[varunagrawal]

@acxz is this resolved?

[acxz]

Nope not yet. see #336 for a wip solution

[acxz]

Update:

Looks like intel released a better migration guide: https://docs.oneapi.com/versions/latest/onetbb/tbb_userguide/Migration_Guide/Task_API.html

Based on that I updated my attempt: https://github.com/acxz/gtsam/tree/fix/tbb-deprecation