Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCOLAMD] fix set but unused variable Int cs #39

Closed
wants to merge 2 commits into from
Closed

[CCOLAMD] fix set but unused variable Int cs #39

wants to merge 2 commits into from

Conversation

acxz
Copy link

@acxz acxz commented May 11, 2020

Resolves #38

@acxz
Copy link
Author

acxz commented May 21, 2020

@DrTimothyAldenDavis do you mind taking a look at this?

@DrTimothyAldenDavis
Copy link
Owner

DrTimothyAldenDavis commented May 21, 2020 via email

@DrTimothyAldenDavis
Copy link
Owner

DrTimothyAldenDavis commented May 21, 2020 via email

@acxz
Copy link
Author

acxz commented May 21, 2020

Thx for responding!

No worries.

Didn't realize there was a CLA, mb. I would recommend looking at cla-bot or cla-assisstant to automate this process.

Would this work as a submission of the signed agreement based on:
https://github.com/DrTimothyAldenDavis/SuiteSparse/blob/master/CONTRIBUTOR-LICENSE.txt#L29 ?

The GitHub user, X acxz , has read and understood the Contributor License Agreement located at https://github.com/DrTimothyAldenDavis/SuiteSparse/blob/master/CONTRIBUTOR-LICENSE.txt

@DrTimothyAldenDavis
Copy link
Owner

DrTimothyAldenDavis commented May 29, 2020 via email

@DrTimothyAldenDavis
Copy link
Owner

DrTimothyAldenDavis commented Jul 3, 2020

The variable is used when debugging is enabled. Deleting it breaks the code in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CCOLAMD] Variable cs set but not used
2 participants