Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 4.0.2 #130

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Conversation

Ellon
Copy link
Contributor

@Ellon Ellon commented Oct 3, 2019

Hi,

I noticed the version was not bumped after 4.0.2 release, so I bumped it on this PR.

It was also not bumped for 4.0.1... was this on purpose ?

Cheers!


This change is Reviewable

@dellaert
Copy link
Member

dellaert commented Oct 3, 2019

We sometimes make little mistakes like this on purpose, just to keep people on their toes :-) Will merge and kill Travis builds

@dellaert dellaert merged commit a28806b into borglab:master Oct 3, 2019
@Ellon Ellon deleted the fix-4.0.2-version-patch branch October 3, 2019 13:31
@Ellon
Copy link
Contributor Author

Ellon commented Oct 3, 2019

Naughty developers... 😆 Don't forget to update the tag then too. 😉

Cheers!

@dellaert
Copy link
Member

dellaert commented Oct 3, 2019

Hmmm, updating a tag seems to be discouraged. Maybe a new tag 4.0.2a?

@dellaert
Copy link
Member

dellaert commented Oct 3, 2019

Although that sounds like alpha.

@Ellon
Copy link
Contributor Author

Ellon commented Oct 3, 2019

It is very discouraged... :/ Forcing the tag update would keep the repo in the "right state" (tag naming matching code version), but may mess with some clones/forks of the repo. Changing the tag name would make it look like a newer version, when in fact it's not.

Not sure what to do here... I think it will be up to you guys to chose one.

@Ellon
Copy link
Contributor Author

Ellon commented Oct 3, 2019

Personally I would update the tag and warn the community about the mistake. I believe most of people using GTSAM would be able to handle this update.

@dellaert
Copy link
Member

dellaert commented Oct 3, 2019

@varunagrawal could you move the tag and post to google group?

@dellaert
Copy link
Member

dellaert commented Oct 7, 2019

GTSAM uses Gitflow, see https://nvie.com/posts/a-successful-git-branching-model/

@dellaert
Copy link
Member

dellaert commented Oct 7, 2019

And https://gtsam.org/notes/Contributing.html :-)

@Ellon
Copy link
Contributor Author

Ellon commented Oct 7, 2019

Oh, OK, so I messed up when I proposed the merge on top of master... 😅 Sorry about that. I'll take more care next time.

@varunagrawal
Copy link
Collaborator

Yup I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants