Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find python if using Default #553

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Find python if using Default #553

merged 1 commit into from
Oct 2, 2020

Conversation

varunagrawal
Copy link
Collaborator

This PR updates the FindPython cmake call to only happen when the Default argument is used.

@varunagrawal varunagrawal added python Related to python wrapper cmake Related to CMake and build system labels Oct 2, 2020
@varunagrawal varunagrawal self-assigned this Oct 2, 2020
@varunagrawal
Copy link
Collaborator Author

@johnwlambert hopefully this should fix your issue.

@varunagrawal varunagrawal merged commit 3f3e286 into develop Oct 2, 2020
@varunagrawal varunagrawal deleted the fix/find-python branch October 2, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

Assignees

@varunagrawal varunagrawal

Labels
cmake Related to CMake and build system python Related to python wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @ProfFan