Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLVM repo keys #560

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Fix LLVM repo keys #560

merged 4 commits into from
Oct 14, 2020

Conversation

ProfFan
Copy link
Collaborator

@ProfFan ProfFan commented Oct 10, 2020

@ProfFan
Copy link
Collaborator Author

ProfFan commented Oct 11, 2020

@johnwlambert Please review this :)

@johnwlambert
Copy link
Contributor

Looks good, thanks @ProfFan for adding this fix.

Would you mind adding a few more inline comments before we merge, just to increase the readability? Perhaps something like

# We need to use a keyserver because.... we use this keyserver because...
# matrix.version 9 represents ...
# 15CF4D18AF4F7421 is the hash for ...
if [ "${{ matrix.compiler }}" = "clang" ] && [ "${{ matrix.version }}" = "9" ]; then
            gpg --keyserver pool.sks-keyservers.net --recv-key 15CF4D18AF4F7421
            gpg -a --export 15CF4D18AF4F7421 | sudo apt-key add -

@ProfFan
Copy link
Collaborator Author

ProfFan commented Oct 12, 2020

I think as this is under clang if it's pretty self-explanatory...

@dellaert
Copy link
Member

I think as this is under clang if it's pretty self-explanatory...

Please be responsive to the reviewer's comment, rather than dismissive.

Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement John's comment

@ProfFan ProfFan requested a review from dellaert October 12, 2020 15:54
@ProfFan
Copy link
Collaborator Author

ProfFan commented Oct 12, 2020

@johnwlambert @dellaert done

@ProfFan
Copy link
Collaborator Author

ProfFan commented Oct 12, 2020

@dellaert Please accept :)

@dellaert
Copy link
Member

@dellaert Please accept :)

Did you actually read John’s comment? Maybe I’m just missing where you explain why we need a key server etc as he asked…

@johnwlambert
Copy link
Contributor

johnwlambert commented Oct 14, 2020

Hi @ProfFan, we need this to merge the SFM Example BAL updates, I think a brief comment about why we needed the keyserver would help. You could also consider making that hash key a bash variable, so that is a bit easier to read

@ProfFan
Copy link
Collaborator Author

ProfFan commented Oct 14, 2020

@dellaert I think I have addressed @johnwlambert 's comments, could you approve this PR so we can merge?

@dellaert dellaert merged commit e11f564 into develop Oct 14, 2020
@dellaert dellaert deleted the fix/clang-keys branch October 14, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants