Feature/wrap sfm data #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay-krishnan
requested changes
Oct 19, 2020
akshay-krishnan
requested changes
Oct 19, 2020
akshay-krishnan
requested changes
Oct 22, 2020
removed commented code
akshay-krishnan
requested changes
Oct 24, 2020
dellaert
reviewed
Oct 25, 2020
akshay-krishnan
requested changes
Oct 28, 2020
akshay-krishnan
approved these changes
Nov 2, 2020
dellaert
approved these changes
Nov 2, 2020
|
Mac builds are broken by upstream boost issue boostorg/serialization#219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written a python unittest for the functions I've used from the SfmData and SfmTrack wrapper. Will add tests for other methods after I've had some doubts clarified.
Changed "measurements" in SfmTrack to Measurements, to maintain uniformity in how vectors are named (specializations.h). That change was also reflected in all other files using track.measurements