Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant calls to error() in NonLinearOptimizer #585

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

jlblancoc
Copy link
Member

A simple fix. error() was called two times in each iteration (or 3 times if verbose-level was high enough).
Surely not a huge efficient loss, haven't measured it, but for large graphs it might be noticeable.

Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal varunagrawal merged commit a765231 into develop Nov 8, 2020
@varunagrawal varunagrawal deleted the feature/lm-iteration-hook branch November 8, 2020 19:52
@jlblancoc
Copy link
Member Author

LGTM

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants