Documentation for compiling on Windows #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesheffler
reviewed
Jan 7, 2021
mikesheffler
reviewed
Jan 7, 2021
There was a problem hiding this comment.
@varunagrawal I just noticed this this evening (sorry!). I did a quick scan over it and noticed one typo.
In terms of substantive stuff, I usually used CMake outside of Visual Studio and then just use Visual Studio to build the .sln produced by CMake, so I'd like to actually try to follow the steps as written. I'll try to do it today (Thursday - Friday).
mikesheffler
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #588. Only documentation, no code changes.
@mikesheffler since you are a regular Windows user, I am looking forward to feedback from you.
cc @dellaert