Fix can be marked override warning #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_smart_factor * 'develop' of github.com:borglab/gtsam: (65 commits) type in test hidden by duplicate test values auto and reserve fewer replace sparseJacobian with "fast" version disambiguate double template >> fix comment and remove whitespace diff remove InPlace jacobian from .h file remove unnecessary function overloads and typedefs use standard function to check for empty string fix bug in Pose2 print formatting revert Matrix.h remove templating while maintaining efficiency Templating still used in cpp file for generic-ness, but not exposed anymore move SparseMatrixBoostTriplets typedef to gfg add known issues section with info about march=native Revert "upgrade minimum required Boost version to 1.67." upgrade minimum required Boost version to 1.67. populate sparse matrix with `insert` rather than `setFromTriplets` About 5% speed improvement. eliminate copy/pasta from SparseEigen with generic version of sparseJacobian more generic sparseJacobianInPlace function add generic optional parameters to sparseJacobian Also, the unit test changed due to a 0 entry that was previously wrongly included in the b-column of the sparse representation. ...
|
@varunagrawal, you were faster than I was to fix the Btw @varunagrawal, I thought that it'll be better to just fix all of those warnings at once... Feel free to ignore it or merge it! |
…-1 into fix/warning_in_smart_factor * 'fix/warning_in_smart_factor' of github.com:ToniRV/gtsam-1:
|
Ok, here it is! Feel free to add or ignore :) |
|
@varunagrawal or anyone that gets to it before me, feel free to merge after CI passes. Thanks Toni! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.