Fix GTSAM MATLAB Wrapper #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b28b3570d Merge pull request #30 from borglab/feature/remove_install cc2b07193 Cleanup 610ca176b Allow GTWRAP to be installed in a prefix 193b922c6 Merge pull request #29 from borglab/feature/remove_install 6d2b6ace6 fix path to package e5f220759 clean up some leftover code b0b158a0a install python package as a directory 3f4a7c775 Allow usage without install into global env 5040ba415 Merge pull request #28 from borglab/readme-update 14a7452fe updated README Getting Started section git-subtree-dir: wrap git-subtree-split: b28b3570d221b89f3568f44ed439d3a444903570
|
@varunagrawal @jlblancoc @dellaert Could you do a quick review on this? This PR should also unbreak the macOS Python CI because of upstream changes in Homebrew. |
varunagrawal
approved these changes
Feb 16, 2021
| # We use DESTINATION (instead of TYPE) so we can support older CMake versions. | ||
| install(PROGRAMS scripts/pybind_wrap.py scripts/matlab_wrap.py | ||
| DESTINATION ${CMAKE_INSTALL_BINDIR}) | ||
| install(PROGRAMS scripts/pybind_wrap.py scripts/matlab_wrap.py TYPE BIN) |
There was a problem hiding this comment.
Should we be using TYPE? I left a comment saying that we need DESTINATION for older versions of CMake.
There was a problem hiding this comment.
Agreed :) I'll push a change to this to wrap (but let's first merge this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should
wrapto latest version