Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and formatting #865

Merged
merged 5 commits into from
Aug 29, 2021

Conversation

dellaert
Copy link
Member

I wanted to familiarize myself again with smart factors to properly advise @lucacarlone and co on the new factors. This adds two README files and cleans up a number of factors.

@dellaert dellaert added cleanup Help clean up old/obsolete aspects of GTSAM docs Update to docs or README without code changes labels Aug 29, 2021
Copy link
Contributor

@lucacarlone lucacarlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments, but I agree with the changes and READMEs

gtsam/slam/ProjectionFactor.h Outdated Show resolved Hide resolved
gtsam/slam/ReadMe.md Outdated Show resolved Hide resolved
gtsam/slam/ReadMe.md Show resolved Hide resolved
gtsam/slam/ReadMe.md Show resolved Hide resolved
gtsam/slam/ReadMe.md Show resolved Hide resolved
gtsam/slam/SmartFactorBase.h Outdated Show resolved Hide resolved
gtsam_unstable/slam/ReadMe.md Show resolved Hide resolved
gtsam_unstable/slam/ReadMe.md Show resolved Hide resolved
@dellaert dellaert merged commit f3c65d9 into feature/cameraTemplateForAllSmartFactors Aug 29, 2021
@dellaert dellaert deleted the feature/readmes branch August 29, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Help clean up old/obsolete aspects of GTSAM docs Update to docs or README without code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants