Modernize discrete factor graphs (a bit) #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
added
cleanup
ProfFan
reviewed
Nov 21, 2021
| CSP::sharedValues mpe = csp.optimalAssignment(ordering); | ||
| // GTSAM_PRINT(*mpe); | ||
| auto mpe = csp.optimalAssignment(ordering); | ||
| // GTSAM_PRINT(mpe); | ||
| CSP::Values expected; | ||
| insert(expected)(WA.first, 1)(CA.first, 1)(NV.first, 3)(OR.first, 0)( |
There was a problem hiding this comment.
Sorry for jumping in, but I remember last time you asked me to wrap some discrete in Python, and I realized this is not easy to wrap. Could we drop this syntax (which is boost specific) and use some C++11-only style instead?
|
Looks good to me |
xsj01
approved these changes
Nov 30, 2021
|
Thanks @xsj01, but note reviewers don't merge :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically an API change, but discrete is very seldomly used, if ever, except by me I think.