Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eigen Serialization Fix #944

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Eigen Serialization Fix #944

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f4218d
update the packaged Eigen to 3.3.9
varunagrawal Nov 29, 2021
a80308d
Revert "update the packaged Eigen to 3.3.9"
varunagrawal Nov 29, 2021
120a69d
add workaround for Eigen serialization issue
varunagrawal Nov 29, 2021
c0b65b2
Add Eigen/Core header
varunagrawal Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion gtsam/base/serialization.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@

#pragma once

#include <sstream>
#include <Eigen/Core>
#include <fstream>
#include <sstream>
#include <string>

// includes for standard serialization types
Expand All @@ -40,6 +41,17 @@
#include <boost/archive/binary_oarchive.hpp>
#include <boost/serialization/export.hpp>

// Workaround a bug in GCC >= 7 and C++17
// ref. https://gitlab.com/libeigen/eigen/-/issues/1676
#ifdef __GNUC__
#if __GNUC__ >= 7 && __cplusplus >= 201703L
namespace boost { namespace serialization { struct U; } }
namespace Eigen { namespace internal {
template<> struct traits<boost::serialization::U> {enum {Flags=0};};
} }
#endif
#endif

namespace gtsam {

/** @name Standard serialization
Expand Down