-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow base 4.12, as released with GHC 8.6. #15
Conversation
There's actually an old version of vector-binary-instances that the solver is able to use on GHC 8.6, but I presume that the latest version would be better to use if possible. This also adds 8.6 to the Travis configuration.
This seems to break CI. |
@bgamari Can you trigger a build of master, please? I don't think that this PR is causing it; rather, at some point since the last Travis run, At the component level this is actually feasible (i.e., not a cycle), and haskell/cabal#1575 is tracking that. Edit: Actually, I think it might not be manifesting on master. |
Actually, thinking on it more, the bug should trigger on master, since it's also affecting the 7.10 and 8.0 builders. I'm not entirely sure why the solver isn't finding solutions that it previously could - maybe revisions? |
I've got it and it's alarmingly simple: the previous |
Indeed, I don't believe such an option exists. That being said, I don't think we should let this issue be a blocker. For the time being, I think manually removing any uses of In the long term, what we should look into is putting the benchmarks into a separate |
Sounds sensible. I've gone ahead and hand-edited |
I've opened #16 to get rid of the manual hacks we had to put in the generated |
There's actually an old version of vector-binary-instances that the
solver is able to use on GHC 8.6, but I presume that the latest
version would be better to use if possible.
This also adds 8.6 to the Travis configuration.