Update eventcore with temporary bugfix #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linked0
approved these changes
Dec 2, 2020
TrustHenry
approved these changes
Dec 2, 2020
|
Ok it looks like the commit brought in too many changes. I'll fix this up soon. Edit: also one initializer was wrong, but I fixed it up. |
AndrejMitrovic
force-pushed
the
fixup-crash
branch
from
184f23b
to
0a47fe3
Compare
kchulj
approved these changes
Dec 2, 2020
This uses our own branch which includes a bugfix for bosagora#1367
AndrejMitrovic
force-pushed
the
fixup-crash
branch
from
0a47fe3
to
4333449
Compare
|
Seems to be green, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses our own branch which includes a bugfix for #1367
Please merge this soon. We also need to notify RNS solutions to make sure to update their submodules when they fetch the latest version of Agora.
Thanks goes to @Geod24.