DUB: Require most recent compiler / dub, simplify #2160
Conversation
|
This allowed me to find #2158 BTW, so an immediate win. |
|
Alpine needs to be updated |
|
Actually what we needed was bosagora/docker-agora-builder#13 since we don't use upstream images (but it doesn't hurt to update them either). |
|
@omerfirmak : I blame you: dlang/dub#2142 |
That is happening a lot these days. |
Codecov Report
@@ Coverage Diff @@
## v0.x.x #2160 +/- ##
==========================================
- Coverage 89.15% 88.56% -0.59%
==========================================
Files 143 142 -1
Lines 13809 13722 -87
==========================================
- Hits 12311 12153 -158
- Misses 1498 1569 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| source/scpp/build/*.o | ||
| source/scpp/build/*.obj |
There was a problem hiding this comment.
Also a workaround for the DUB issue.
Since we now pass C++ aggregates by values, we need the latest LDC. In addition, we rely on recent enhancements to DUB, e.g. for `-preview=in`, or `mainSourceFile`, and if one uses a recent LDC, they likely have access to a recent DUB as well.
We used to have this hard-coded list because of DUB issue 1474, which was part of DUB v1.24.0, so we can now delete this workaround.
|
💚 |
Note that LDC
v1.27.0-beta1has been released so it's not going to stay the most recent version for long.