More Rust dependency updates for upcoming v1.13 release #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit builds `chrono` only with the features that we need to avoid pulling in an additional (and older) `time` dependency. This dependency won't completely fall out of Cargo.lock until coldsnap, tough, and testsys have been updated as well.
jpculp
commented
Mar 3, 2023
Comment on lines
+67
to
+68
| # testsys uses an old version of time | ||
| { name = "time", version = "=0.1.43" }, |
There was a problem hiding this comment.
We'll want to remove this whenever we update testsys.
jpculp
commented
Mar 3, 2023
| @@ -74,10 +74,11 @@ checksum = "64cb94155d965e3d37ffbbe7cc5b82c3dd79dd33bd48e536f73d2cfb8d85506f" | |||
|
|
|||
| [[package]] | |||
| name = "assert-json-diff" | |||
| version = "2.0.2" | |||
| version = "1.1.0" | |||
There was a problem hiding this comment.
This is a dev-dependency for infrasys and aws-smithy-protocol-test. From what I can tell the infrasys tests don't mine dropping to the same version as aws-smithy, so we can avoid pulling multiple versions.
webern
approved these changes
Mar 6, 2023
jpmcb
approved these changes
Mar 6, 2023
I did |
stmcginnis
approved these changes
Mar 6, 2023
webern
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2763
Description of changes:
Updates AWS SDK for Rust,
aws-smithy,coldsnap, andtough, while addressing any breaking changes.Also includes changes to remove an unnecessary
time0.1.x dependency, although it won't be completely removed until the next release oftestsys/bottlerocket-types.Testing done:
Built and launched
aws-k8s-1.24(x86_64) and ran through some basic operations.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.