Default to cgroup v2 for dev and k8s-1.26 variants #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make systemd set up a cgroup v2 hierarchy on boot by default for the
development/-dev variants. The old default of using cgroup v1 may still
be achieved via a setting applied using `apiclient`
apiclient set -j '{"settings": {"boot": {"init": {"systemd.unified_cgroup_hierarchy": ["0"]}}}}'
or via user data:
[settings.boot]
reboot-to-reconcile = true
[settings.boot.init]
"systemd.unified_cgroup_hierarchy" = ["0"]
Signed-off-by: Markus Boehme <[email protected]>
Make systemd set up a cgroup v2 hierarchy on boot by default for the k8s-1.26
variants. The old behavior of using cgroup v1 may still be achieved via a
setting applied using `apiclient`
apiclient set -j '{"settings": {"boot": {"init": {"systemd.unified_cgroup_hierarchy": ["0"]}}}}'
or via user data:
[settings.boot]
reboot-to-reconcile = true
[settings.boot.init]
"systemd.unified_cgroup_hierarchy" = ["0"]
Signed-off-by: Markus Boehme <[email protected]>
markusboehme
changed the title
stmcginnis
approved these changes
Mar 9, 2023
gthao313
approved these changes
Mar 9, 2023
|
Running the conformance tests now. The code LGTM. |
|
|
bcressey
approved these changes
Mar 10, 2023
|
Thank you Tianhao! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2843
Description of changes: Make the
*-devand*-k8s-1.26variants use cgroup v2 by default.Testing done:
apiclient) work as expected via inspection of/sys/fs/cgroupon the host.aws-k8s-1.24variant for availability of a working EKS cluster.*-k8s-1.26variants!Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.