[1.14.x] netdog: set IPv6 accept-ra for primary interface via config rather than sysctl #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the necessary structures to wicked in order to support setting the `accept_ra` IPv6 option via interface config. Doing this in config allows wicked to manage this option and avoids any race conditions that may occur between wicked and the kernel when attempting to set this via sysctl. (cherry picked from commit 91e2cc9)
Previously, we set the IPv6 accept-ra setting for the primary interface via `systemd-sysctl` during the wicked install helper. Setting this sysctl via the helper can cause a race condition between the kernel and wicked. The kernel sets a flag indicating a router advertisement has been received (`IF_RA_RCVD`), but only after it completes duplicate address detection and decides whether to send a router solicitation. If the sysctl isn't set by the time duplicate address detection completes, the solicitation doesn't happen and the `IF_RA_RCVD` flag doesn't get set. wicked uses this flag to decide whether or not to kick off the state machine that handles DHCP6. This change adds the accept-ra setting to the interface config if the primary interface is set up via kernel command line. The primary interface is supplied via kernel command line for AWS and VMware variants. This change also removes the accept-ra setting from the `systemd-sysctl` config. Allowing wicked to manage this setting eliminates any chance of races between sysctl/kernel/wicked. (cherry picked from commit 5ed812d)
markusboehme
approved these changes
Jun 20, 2023
zmrow
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to #3143
A separate PR will be opened by @markusboehme for the related patches to
wickedDescription of changes:
In the future we will support a network config setting that sets this in config for any interface specified.
Testing done:
See testing in #3159
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.