Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not being able to detect sys-wine #3526

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

underlinejakez
Copy link

Description

For some reason, when building manually, bottles can't detect the base wine installation. Output of the problem:

/bin/sh: line 1: /app/bin/wine: cannot execute: required file not found
17:44:25 (INFO) Runners found:
	 - soda-9.0-1
	 - sys-

This solves, but its weird that it don't happen on the flathub build.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I built and installed manually using flatpak run org.flatpak.Builder --user --install-deps-from=flathub --install --force-clean build-dir com.usebottles.bottles.yml from master and after the modification.

@mirkobrombin
Copy link
Member

Thanks for your contribution. This is indeed weird, need to test it locally on my end

Copy link
Contributor

Pylint result on modfied files:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants