Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile/verification screen tests 417 #432

Merged
merged 4 commits into from
Oct 29, 2022
Merged

Mobile/verification screen tests 417 #432

merged 4 commits into from
Oct 29, 2022

Conversation

egemenatikk
Copy link
Contributor

I finished implementation of verification screen tests.

I tested:

  • whether the verification screen contains the verify button or not
  • whether the verification screen contains all four verification code digit fields or not
  • whether verify button is activated when only first three digits are entered or not
  • whether verify button is activated when only first and fourth digits are entered or not
  • whether verify button is activated all digits are entered or not.

I also made some changes in my countdown timer implementation to dispose the timer when the verification screen is disposed.

This PR closes #417 .

@egemenatikk
Add tests for verification screen
517c2b9 
Add dispose method to verification screen in order to dispose timer after disposing the verification screen
@egemenatikk
Fix small bug in countdown timer
7ec3fa4 
After changes I made in the last commit, when request another code button is pressed timer was pacing up, I fixed that bug
@egemenatikk
Fixed countdown timer length
263eac2 
While fixing the previous bug I lowered countdown time to 15, now I changed it back to 180 seconds
@egemenatikk egemenatikk added priority-medium Medium level priority issue status-needreview A review to the issue is needed mobile Mobile related items tests Related to testing labels Oct 29, 2022
@egemenatikk egemenatikk self-assigned this Oct 29, 2022
@egemenatikk egemenatikk mentioned this pull request Oct 29, 2022
Closed
3 tasks
@egemenatikk egemenatikk linked an issue Oct 29, 2022 that may be closed by this pull request
Mobile: Writing Tests for Verification Screen #417
Closed
3 tasks
bahricanyesil
bahricanyesil approved these changes Oct 29, 2022
View reviewed changes
learnify/mobile/test/verification_screen_test.dart Outdated
void main() {
testWidgets("Test verification screen", (WidgetTester tester) async {
final VerificationScreen verificationScreen =
VerificationScreen(email: "[email protected]");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a realistic email can be better, please change this. Other than that, all seem okay. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bahricanyesil bahricanyesil added Status: Completed Issue is solved and removed status-needreview A review to the issue is needed labels Oct 29, 2022
@egemenatikk egemenatikk merged commit 95b79d2 into dev Oct 29, 2022
@bahricanyesil bahricanyesil deleted the mobile/verification-screen-tests-417 branch October 30, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahricanyesil bahricanyesil bahricanyesil approved these changes

@ezgy ezgy Awaiting requested review from ezgy

@onurkomurcu onurkomurcu Awaiting requested review from onurkomurcu

Assignees

@egemenatikk egemenatikk

Labels
mobile Mobile related items priority-medium Medium level priority issue Status: Completed Issue is solved tests Related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile: Writing Tests for Verification Screen
2 participants
@egemenatikk @bahricanyesil