Add PHP justinrainbow/json-schema implementation #1512
Conversation
|
Very nice, thanks for this! Will do a release later tonight or tomorrow. Good luck with the implementation (and stay in touch)! |
| "description": "These sources contains the test harness implementation for Bowtie", | ||
| "license": "MIT", | ||
| "require": { | ||
| "justinrainbow/json-schema": "dev-master" |
There was a problem hiding this comment.
If perchance you're interested in a follow up PR, changing this to instead be a fixed version, (perhaps as soon as you publish one if that's not yet happened?) would be nice, and then relying on Dependabot to update it.
As is, right now the version information shown at https://bowtie.report/#/implementations/php-justinrainbow-json-schema (which is live, congrats!) won't be useful to someone, since it just says dev-master, but someone won't know what commit that corresponds to even if it was HEAD at some point in time.
There was a problem hiding this comment.
Thanks for the heads up. This is on my radar. Since the latest version is having issues with PHP 8.3 I've decided to use dev-master for now. But your points are very valid. Should be picked up in the near future.
This PR adds an implementation for justinrainbow/json-schema (written in PHP).
The PR was drafted using the instructions if anything is missing or overlooked please feel free to comment.
I'm currently one of the maintainers of
justinrainbow/json-schemawhich we are reviving. First order of business is getting the library back into an actively maintained state. Which is one of the main reasons of opening this PR.📚 Documentation preview 📚: https://bowtie-json-schema--1512.org.readthedocs.build/en/1512/